Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output codec without delimiter #641

Closed
mihaitodor opened this issue Jan 25, 2021 · 2 comments · Fixed by #642
Closed

Output codec without delimiter #641

mihaitodor opened this issue Jan 25, 2021 · 2 comments · Fixed by #642
Labels
enhancement outputs Any tasks or issues relating specifically to outputs

Comments

@mihaitodor
Copy link
Member

Looking at the available output codecs, I noticed that all-bytes truncates on each message and delim doesn't support an empty delimiter.

Would you consider removing the non-empty delimiter restriction in the delim output codec? I need this when using the chunker input codec that I added in #640 for the use case of transferring a large file from Azure to a local file.

@Jeffail
Copy link
Member

Jeffail commented Jan 25, 2021

Ahh of course, rather than allow empty delimiters it's probably better for discovery if we add an explicit append codec, that'll simply write the raw data.

Edit: but I'd also say it's fine to simply instantiate a delim codec with an empty delimiter under the hood to make the implementation simpler.

@Jeffail Jeffail added enhancement outputs Any tasks or issues relating specifically to outputs labels Jan 25, 2021
@mihaitodor
Copy link
Member Author

mihaitodor commented Jan 25, 2021

append. Of course! I was struggling to figure out what to name it 😁 Coming right up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement outputs Any tasks or issues relating specifically to outputs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants