Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Validation Options or Better Logging for Missing Dependencies for GameObjects in Scene #3

Open
Jeffan207 opened this issue May 29, 2022 · 0 comments

Comments

@Jeffan207
Copy link
Owner

Jeffan207 commented May 29, 2022

Right now when USyrup fails to inject an GameObject in the scene it will through a generic MissingDependencyException. This differs from when we validate the graph where we throw a much more helpful error message detailing all the missing dependencies. We should do one of the following:

  1. Validate all GameObjects in the scene that are injectable during graph validation. This will be a bit more expensive to do so we can maybe put it behind a flag.
  2. Upon failing to inject a game object take the time to build the missing dependencies in the graph and output a similar message as we do in graph validation.

There are pros/cons to each. I'm leaning toward (2) because its simpler and makes a bit more sense semantically.

@Jeffan207 Jeffan207 changed the title Add Validation Options for GameObjects in Scene Add Validation Options or Better Logging for Missing Dependencies for GameObjects in Scene May 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant