Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize main analyzer with event type plugins #14

Closed
hansenjo opened this issue Oct 16, 2013 · 3 comments
Closed

Generalize main analyzer with event type plugins #14

hansenjo opened this issue Oct 16, 2013 · 3 comments
Assignees
Milestone

Comments

@hansenjo
Copy link
Member

Different event types (physics, scalers, slow control, etc.) need different processing chains. These chains should be made pluggable so users can easily extend or replace them. This also helps split the large main analyzer into smaller and hopefully more maintainable subclasses.

@rwmichaels
Copy link
Member

I made a pull request with plug-ins for Hall A Scalers, and the EPICS events can also be a plug-in but there is a currently an EPICS handler which is a member of THaAnalyzer. The latter makes sense because it allows to re-use the existing THaEpics and THaOutput::ProcEpics in such a way as to make the user interface identical to before, plus I think that both Hall A and C does EPICS insertions the same way. In any case, if preferred, someone can now write an EPICS handler plug-in, imitating the Hall A scalers plug-in as an example. Likewise, someone can write a hall C scaler plug-in.

@hansenjo
Copy link
Member Author

I will merge this shortly. I'll collapse the history a bit and I see if
it compiles on all my test platforms.

Ole

@hansenjo
Copy link
Member Author

Closed by commit d2a4007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants