Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update value of BeamLineConstants.ECAL_FACE #952

Closed
normangraf opened this issue Mar 8, 2023 · 2 comments · Fixed by #983
Closed

Update value of BeamLineConstants.ECAL_FACE #952

normangraf opened this issue Mar 8, 2023 · 2 comments · Fixed by #983
Assignees
@normangraf

Comments

@normangraf
Copy link
Contributor

The calorimeter was moved downstream for the 2019 and 2021 runs, but the value of ECAL_FACE in tracking/src/main/java/org/hps/recon/tracking/BeamlineConstants.java was not updated. This means that when comparing the track state as returned by TrackStateUtils.getTrackStateAtECal(track) to the cluster position as returned by cluster.getPosition() they are at very different z locations:

EcalFaceZPosition

This had been fixed in git branch iss914, but was not merged into the master branch before that issue was closed.
@normangraf
Copy link
Contributor Author

The tracking code will have to be modified to reference ECAL_FACE_ENGINEERING_RUNS when reconstructing data from 2015 and 2016.

@normangraf
Copy link
Contributor Author

Other variables in BeamlineConstants should be reviewed and updated as necessary for the 2019 and 2021 runs.

@normangraf normangraf self-assigned this Mar 8, 2023
@cbravo135 cbravo135 linked a pull request Apr 21, 2023 that will close this issue
Iss952 Clean up #983
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@normangraf normangraf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iss952 Clean up JeffersonLab/hps-java
1 participant
@normangraf