Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is pluralizing a good idea? #64

Open
enriquemorenotent opened this issue Dec 16, 2014 · 0 comments
Open

Is pluralizing a good idea? #64

enriquemorenotent opened this issue Dec 16, 2014 · 0 comments

Comments

@enriquemorenotent
Copy link

I was looking at this line of code

https://github.com/JeffreyWay/Laravel-Test-Helpers/blob/master/src/Way/Tests/Should.php#L28

and I start wondering if pluralizing is a good idea. Sure, it works with assertEquals, but not all asserts end with the s character. By far.

// This works
Assert::equal();

// This doesn't
Assert::count();
Assert::empty();

Maybe it would be a better idea to let the user write himself the s.

// This works
Assert::equals();
Assert::count();
Assert::empty();

What do you think, @JeffreyWay ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant