Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : allow aws secrets to be passed via environment #12

Closed
beaussan opened this issue Jan 12, 2020 · 2 comments · Fixed by #42
Closed

feat : allow aws secrets to be passed via environment #12

beaussan opened this issue Jan 12, 2020 · 2 comments · Fixed by #42
Labels
enhancement New feature or request help wanted Extra attention is needed state: has pr Already has a PR

Comments

@beaussan
Copy link

Putting aws keys directly in the angular json, accessible to all the devs is like giving them all the secret key.

I think users should be allowed to pass it via env.
@Jefiozie
Copy link
Owner

Thanks @BEAUSSART, I already thought about this as a new feature. Do you like making a PR for this?

@Jefiozie Jefiozie added enhancement New feature or request help wanted Extra attention is needed labels Jan 12, 2020
@Jefiozie Jefiozie changed the title Security : allow aws secrets to be passed via environment feat : allow aws secrets to be passed via environment Jan 12, 2020
@beaussan
Copy link
Author

I can maybe do it tomorrow, will keep you posted :)

This was referenced Jan 15, 2020
Closed
Merged
@Jefiozie Jefiozie added the state: has pr Already has a PR label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed state: has pr Already has a PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow config to be passed via env beaussan/ngx-aws-deploy
Allow config to be passed via env
2 participants
@beaussan @Jefiozie