Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rolling Stock: Teleport back to depot #20

Closed
Leif-The-Head opened this issue Nov 7, 2021 · 4 comments · Fixed by #21
Closed

Rolling Stock: Teleport back to depot #20

Leif-The-Head opened this issue Nov 7, 2021 · 4 comments · Fixed by #21
Assignees
Labels
enhancement New feature or request

Comments

@Leif-The-Head
Copy link
Collaborator

Leif-The-Head commented Nov 7, 2021

Not only Jester in Discord asked for it, I also already thought this was neat.

Proposed functionality:

  • "Reset Rolling Stock" Menu
  • choose Rolling Stock via a list that shows type, number, name (we have that already) and location.
  • set brakes if applicable (handbrakes should be fine, air brakes are influenced by whether it has air anyway)
  • set coordinates/rotation to one of a set of coordinates/rotation that are the spawn rails
    • need to be extracted first
    • proximity check to determine which spot is free before placing
    • in case of no free spots: Error
@Leif-The-Head Leif-The-Head added the enhancement New feature or request label Nov 7, 2021
@JennyKmu JennyKmu added this to To do in RROSE - v0.3.7 via automation Nov 7, 2021
@JennyKmu JennyKmu self-assigned this Nov 7, 2021
@JennyKmu
Copy link
Owner

JennyKmu commented Nov 7, 2021

Pushed branch 'feature_rs_teleport_depot' for further testing.

@JennyKmu
Copy link
Owner

JennyKmu commented Nov 7, 2021

The ui shows:
Status | Frame type | Frame number | Frame name | [RESPAWN] | [YEET IT]

Status is in red if the car is below 10m in height (probably below map)

[RESPAWN] checks for available spawn points, and teleports the selected frame to the first one available (same order as for buying menu)
[YEET IT] is more reasonable than the previous feature : it teleports and reorients the frames next to the spawn point, at a different place for each frame, but still at a hight position over the ground (to avoid potential elements on the ground). Drop positions should be behind the spawn (where the tracks would go if you continued them past the deck)

@JennyKmu
Copy link
Owner

JennyKmu commented Nov 7, 2021

First in game test :

  • Properly detected that spawn points 1 and 2 where occupied
  • Properly respawned 3 frames on spawn points 3, 4 and 5, and the respawned frames were not derailed !
  • Frames respawned were 1 Tier 1 flatcar and 2 tier 2 flat cars

@JennyKmu
Copy link
Owner

JennyKmu commented Nov 7, 2021

Test results:

  • [RESPAWN] working properly, tested with all frames, offset for some frame types included.
  • [YEET IT] working as intended. Results uncertain if drop zone occupied by something else (trees, other frames, ...)

@JennyKmu JennyKmu linked a pull request Nov 7, 2021 that will close this issue
@JennyKmu JennyKmu moved this from To do to Done in RROSE - v0.3.7 Nov 7, 2021
@JennyKmu JennyKmu closed this as completed Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants