Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor overflow #24

Closed
JennyKmu opened this issue Nov 7, 2021 · 3 comments · Fixed by #50
Closed

Cursor overflow #24

JennyKmu opened this issue Nov 7, 2021 · 3 comments · Fixed by #50
Labels
bug Something isn't working
Projects
Milestone

Comments

@JennyKmu
Copy link
Owner

JennyKmu commented Nov 7, 2021

When there is exactly 10 items in a menu, there is some interaction with cursor movement making it possible to go to 11th line (causing an error if trying to edit there)

@JennyKmu JennyKmu added the bug Something isn't working label Nov 7, 2021
@JennyKmu JennyKmu added this to the v0.3.7 milestone Nov 7, 2021
@Leif-The-Head
Copy link
Collaborator

Which menu exactly? Or all of them?
I already have an idea why this happens.

@JennyKmu
Copy link
Owner Author

JennyKmu commented Nov 7, 2021

It happened in the test save you sent me when editing loco/tender contents (since in that menu you get exactly 10 lines, which is the limit for multi-page display. I suspect it will do the same for all menus since they rely on the same structure. The fix isn't too complicated since there's a Boolean which determines whether the lines are split into pages or not. So simply making page-up and page-do to not do anything if that bool is False should solve the issue (haven't had a chance to do it yet)

@JennyKmu JennyKmu modified the milestones: v0.3.7, v0.3.8 Nov 9, 2021
@JennyKmu
Copy link
Owner Author

This issue will be corrected along with the reworked terminal user interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

2 participants