Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the need for jsonrpc.php in endpoint form field less confusing #10

Closed
murchu27 opened this issue Aug 27, 2021 · 6 comments
Closed
Assignees
Labels
enhancement New feature or request
Projects

Comments

@murchu27
Copy link

When I first downloaded the app I had a little bit of trouble getting it to work, as I hadn't realised that I needed to set the "khanos Endpoint" form field on the "Setup" page to https://myserver.me/jsonrpc.php, rather than just https://myserver.me, which is how I would normally reach Kanboard.

The only reason I realised that jsonrpc.php was needed was because I happened to turn my phone to landscape, and see that the placeholder endpoint also ended in jsonrpc.php. Before that, all I could see in portrait was jsonrpc..., and thought that this was just an imaginary directory on the example server.

It might be worth having a dialog/floating message that tells the user explicitly to specify their endpoint as https://myserver.me/jsonrpc.php.

Or better yet, if it's possible, let the user leave this part off - just specifying https://myserver.me as a "base" API URL, and adding jsonrpc.php in the background. I don't know the ins and outs of the API though, so maybe this wouldn't work for everyone's setup.

Some screenshots:
Screenshot_20210827-072358
Screenshot_20210827-072408

@Jeoxs
Copy link
Owner

Jeoxs commented Aug 27, 2021

Hello! This is understandable. Usually the jsonrpc.php is located on the root, so it's very unlikely that there would be a kanboard instance with the jsonrpc.php located on a different directory.

I'll update the login form and add the jsonrpc.php in the background for the next release

@murchu27
Copy link
Author

Nice one. If there's a chance that the jsonrpc.php isn't at the root, maybe the form could be made to still handle a custom location.

e.g., if the submitted string ends in jsonrpc.php, then use that exact URL.

Otherwise, add on jsonrpc.php in the background, making the assumption that it is at the root.

Maybe there's no need for this though?

@Jeoxs Jeoxs closed this as completed in f0dc16a Aug 27, 2021
@Jeoxs Jeoxs added the enhancement New feature or request label Aug 27, 2021
@Jeoxs Jeoxs added this to To do in Khanos via automation Aug 27, 2021
@Jeoxs Jeoxs self-assigned this Aug 27, 2021
@Jeoxs Jeoxs moved this from To do to Done in Khanos Aug 27, 2021
@Jeoxs
Copy link
Owner

Jeoxs commented Aug 27, 2021

Login URL doesn't need the 'jsonrpc.php' anymore. Users can specify it if needed.

@murchu27
Copy link
Author

Awesome, will test it when this hits pre-release, thanks for the quick turnaround!

@Jeoxs
Copy link
Owner

Jeoxs commented Aug 27, 2021

Awesome, will test it when this hits pre-release, thanks for the quick turnaround!

You're Welcome! It's on the latest release section of the project. You can download it there. The Playstore Update will come in the following days

@murchu27
Copy link
Author

Ah yes, just tested it, works perfectly! Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants