Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributeError is raised when calling select_etfs() with no parameter given #10

Closed
jstesta opened this issue Jun 23, 2021 · 2 comments
Closed

AttributeError is raised when calling select_etfs() with no parameter given #10

jstesta opened this issue Jun 23, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@jstesta
Copy link

jstesta commented Jun 23, 2021

Describe the bug
AttributeError is raised when calling select_etfs() with no parameter given.

Expected behavior
Method returns all ETFs.

Actual behavior
The following error is raised:

Traceback (most recent call last):
File "..snip..\lib\site-packages\FinanceDatabase\json_picker.py", line 113, in select_etfs
json_data = json.loads(request.text).decode("UTF-8")
AttributeError: 'dict' object has no attribute 'decode'

Additional context
Version 0.1.9
@JerBouma
Copy link
Owner

Will look into this later this week. Seems it doesn't select the right JSON file.

@JerBouma JerBouma added the bug Something isn't working label Jun 23, 2021
@JerBouma
Copy link
Owner

Fixed this issue in version 0.1.10, please upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jstesta @JerBouma