Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search Functionality! #2

Open
aadrian opened this issue May 20, 2017 · 6 comments
Open

Add Search Functionality! #2

aadrian opened this issue May 20, 2017 · 6 comments

Comments

@aadrian
Copy link

aadrian commented May 20, 2017

Please add search functionality!

Thank you.

@goxr3plus
Copy link
Contributor

@aadrian I just created search functionality -> Check here #5 and also here -> https://github.com/goxr3plus/fontawesomefx-glyphsbrowser/tree/search-bar-feature .

Awaiting pull request to be accepted .

@goxr3plus
Copy link
Contributor

goxr3plus commented Nov 3, 2017

I have just added Search-Bar feature give it a try :
SearchBar + fontawesomefx-glyphsbrowser-1.3.0.zip

@aadrian
Copy link
Author

aadrian commented Nov 6, 2017

@goxr3plus looks great, thank you! It really improves the usability of the tool!

@ghost
Copy link

ghost commented Nov 6, 2017

@goxr3plus Thanks that's so cool and helpful but why did you use weird font-family in search bar?

@goxr3plus
Copy link
Contributor

@engineerchef It was the default font from the application, so I left it, I will create one more pull request adding more advanced search. So you can search for example all the fonts at one.

@ghost
Copy link

ghost commented Nov 7, 2017

@goxr3plus Thank you for your attention. Great job!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants