Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerabilities Detected #509

Closed
drma-tech opened this issue Mar 19, 2024 · 13 comments
Closed

Vulnerabilities Detected #509

drma-tech opened this issue Mar 19, 2024 · 13 comments
Assignees
Labels
Enhancement New feature or request
Milestone

Comments

@drma-tech
Copy link

image

@Jericho
Copy link
Owner

Jericho commented Mar 19, 2024

StrongGrid does not take a direct dependency on any of the three packages on the screenshot you provided. Maybe one of our dependencies does? But which one????

@Jericho Jericho self-assigned this Mar 19, 2024
@Jericho Jericho added the question Someone is asking a question label Mar 19, 2024
@Jericho
Copy link
Owner

Jericho commented Mar 19, 2024

I know that Pathoschild.Http.FluentClient is referencing System.Net.Http but only if your project is using .netstandard1.3. Does that seem right to you? Is you project targeting .net standard1.x? If so, can you upgrade to a more recent .net? That's probably to easiest and fastest way of getting rid of the vulnarable System.Net.Http reference.

I have no idea where the other two references are coming from though.

@Jericho
Copy link
Owner

Jericho commented Mar 19, 2024

oh and by the way, what lead you to conclude that these dependencies came from StrongGrid in the first place?

@drma-tech
Copy link
Author

image
image
image

@drma-tech
Copy link
Author

If you open it with Visual Studio, you can easily see this, including where the references come from.

@Jericho
Copy link
Owner

Jericho commented Mar 19, 2024

"Transitively referenced by StrongGrid" this pretty much confirms what I said: we don't directly reference any of these packages, but some of our references do.

Like I said, I have a pretty good idea where the System.Net.Http reference comes from but no idea about the other two. And further more, the vulnerable System.Net.Http is used only when you target netstandard1.x Does this apply to your situation? Any chance you can upgrade your platform target(s)?

@Jericho
Copy link
Owner

Jericho commented Mar 19, 2024

As it turns out, all three references are being pulled in by our dependency on Pathoschild.Http.FluentClient:

image

@drma-tech
Copy link
Author

im using .net 8.0. not sure if is using this netstandard

@drma-tech
Copy link
Author

so, its just notify the owner of this component

@Jericho
Copy link
Owner

Jericho commented Mar 19, 2024

When I open the FluentHttp project in Visual Studio and look at their dependencies, I see this:

image

So, while the author of the FluentHttp project might be able to fix the System.Net.Http reference (by dropping support for netstandard1.x, I presume), the other two are being pulled in by even further upstream dependencies.

@Jericho
Copy link
Owner

Jericho commented Mar 19, 2024

Turns out, I was wrong about one specific detail: the FluentHttpClient project is already referencing the patched System.Net.Http package (which is version 4.3.4) as evidenced by:

image

So they may have to go upstream to get this transitive reference upgraded.

@Jericho
Copy link
Owner

Jericho commented May 25, 2024

FluentHttpClient version 4.4.0 has been released. Upgrading our reference to this new release resolves this warning.

@Jericho Jericho added Enhancement New feature or request and removed question Someone is asking a question labels May 25, 2024
@Jericho Jericho added this to the 0.108.0 milestone May 25, 2024
@Jericho
Copy link
Owner

Jericho commented May 26, 2024

🎉 This issue has been resolved in version 0.108.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants