Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further improve how we handle unsupported encodings when parsing InboundEmail webhooks #521

Closed
Jericho opened this issue May 2, 2024 · 1 comment
Assignees
Labels
Enhancement New feature or request
Milestone

Comments

@Jericho
Copy link
Owner

Jericho commented May 2, 2024

There has been several issues raised over the years regarding sections of the InboundEmail payload being encoded with unknown/unsupported encodings and two improvements have been made to lessen the problem:

These two improvements have considerably reduced the problem with encoding but I was thinking we could be smarter than blindly fallback to UTF-8 when an invalid/unsupported encoding is specified. I recently found out about the UTF Unknown project which attempts to determine which encoding was used to encode binary data by probing the content. This would enhance our ability to properly decode a given section of a webhook, even if the encoding is unspecified or invalid.

@Jericho Jericho added the Enhancement New feature or request label May 2, 2024
@Jericho Jericho self-assigned this May 2, 2024
@Jericho Jericho closed this as completed in 4e2ada1 May 5, 2024
@Jericho Jericho added this to the 0.108.0 milestone May 5, 2024
@Jericho
Copy link
Owner Author

Jericho commented May 26, 2024

🎉 This issue has been resolved in version 0.108.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant