Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpClient is actually required #103

Closed
worthy7 opened this issue Feb 19, 2021 · 2 comments
Closed

HttpClient is actually required #103

worthy7 opened this issue Feb 19, 2021 · 2 comments
Assignees
Labels
Bug This change resolves a defect
Milestone

Comments

@worthy7
Copy link
Contributor

worthy7 commented Feb 19, 2021

System.ArgumentNullException: Value cannot be null. (Parameter 'httpClient')
   at ZoomNet.Utilities.OAuthTokenHandler..ctor(OAuthConnectionInfo connectionInfo, HttpClient httpClient, Nullable`1 clockSkew)
   at ZoomNet.ZoomClient..ctor(IConnectionInfo connectionInfo, HttpClient httpClient, Boolean disposeClient, ZoomClientOptions options, ILogger logger)
   at ZoomNet.ZoomClient..ctor(IConnectionInfo connectionInfo, ZoomClientOptions options, ILogger logger)

I'm getting this error when trying to use:
new ZoomClient(connectionInfo) as per the readme

Perhaps make HttpClient a required parameter if it is?

@Jericho
Copy link
Owner

Jericho commented Feb 19, 2021

Thanks for bringing this to my attention.

The httpClient is necessary to send requests to the Zoom API and for other purposes as well but a default one is supposed to be transparently instantiated if the developer does not provide one. You found a scenario where, unfortunately, it's not working as intended.

As a temporary workaround you can use any of the other constructors of the ZoomClient class while I figure out and fix this issue. Something like this:

var zoomClient = new ZoomClient(connectionInfo, (IWebProxy)null);

@Jericho Jericho self-assigned this Feb 19, 2021
@Jericho Jericho added the Bug This change resolves a defect label Feb 19, 2021
@Jericho Jericho added this to the 0.22.0 milestone Feb 19, 2021
@Jericho
Copy link
Owner

Jericho commented Feb 27, 2021

🎉 This issue has been resolved in version 0.22.0 🎉

The release is available on:

Your GitReleaseManager bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This change resolves a defect
Projects
None yet
Development

No branches or pull requests

2 participants