Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] There are double apostrophes ('') in the titles where there should be one ('). #11

Closed
zumbawumba opened this issue Jul 4, 2021 · 6 comments
Assignees

Comments

@zumbawumba
Copy link

Every video file that has an apostrophe in the title, like this:

Mister Magoo's Christmas Carol

Is being indexed in HomeCinema with double apostrophes, like this:

Mister Magoo"s Christmas Carol

Perhaps this is a bug on my end, but all my other software checks fine, and I've never seen such a thing before.

I hope you can duplicate it and fix it. If you need more help/info let me know.

<<<<<<<<<<<<<<<<<<

double apostrophes bug

<<<<<<<<<<<<<<<<<<

Windows 10 64 bit (updated) with North American English keyboard setting

HomeCinema v0.7.1.0 r38

@JerloPH
Copy link
Owner

JerloPH commented Jul 4, 2021

Check the 'name' column on 'info' table on your HomeCinema.db file (You can use SQLite DB Browser).
If its the same as above screenshot, I might have missed something on saving to database.

EDIT: Made change to dev branch that could possibly fix the issue. I'll create a pre-release build file so make sure to try it.
EDIT 2: Link to pre-release: https://github.com/JerloPH/HomeCinema/releases/tag/alpha-v0.7.1.1

@JerloPH JerloPH self-assigned this Jul 4, 2021
@zumbawumba
Copy link
Author

I checked with DB Browser for SQLite and the name was the same in HomeCinemaDB.

I then tried your pre-release alpha-v0.7.1.1 and that appears to have fixed the issue.

I'll continue to test HomeCinemaDB and report back as need be.

@JerloPH
Copy link
Owner

JerloPH commented Jul 5, 2021

Thanks for the feedback!

My theory on that is I've used a method to sanitize the entries so it can be properly inserted into the database. Apostrophe must be doubled in SQL. In the 'dev' branch, I changed this to sanitize only during the insert query. Instead of during the load up screen.

And thanks for rigorously testing. Much appreciated ☺️

@zumbawumba
Copy link
Author

zumbawumba commented Jul 6, 2021

I changed this to sanitize only during the insert query.

Sounds good. Furthermore FYI, this appears to have fixed another related issue, where an apostrophe was being removed, like this:

Original filename:
Bob's Fat Cat

Shows up in HC as:
Bobs Fat Cat

Regardless, I just tested for that issue again, and all seems to be fine now.

thanks

@JerloPH
Copy link
Owner

JerloPH commented Jul 8, 2021

Fixed on dev, not on stable release yet

@JerloPH JerloPH reopened this Jul 8, 2021
@JerloPH
Copy link
Owner

JerloPH commented Jul 10, 2021

Released fix on v0.7.2

@JerloPH JerloPH closed this as completed Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants