Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing else in put saver? #2989

Closed
donleyp opened this issue Oct 8, 2017 · 3 comments
Closed

Missing else in put saver? #2989

donleyp opened this issue Oct 8, 2017 · 3 comments

Comments

@donleyp
Copy link

donleyp commented Oct 8, 2017

See

TiddlyWiki5/core/modules/savers/put.js

Line 73 in 7bdaabc

} if(xhr.status === 200 || xhr.status === 201) {

@sukima
Copy link
Contributor

sukima commented Oct 9, 2017

I do think this is a bug!

pmario referenced this issue Oct 9, 2017
@Jermolene
Better error trapping for WebDAV saver
91b341e 
Without these checks we get a startup crash when using TiddlyWiki in
client-server configuration.
@Arlen22
Copy link
Contributor

Arlen22 commented Oct 11, 2017

I second, since this could possibly result in callback being called twice, breaking a cardinal rule of callbacks.

@tobibeer
Copy link
Contributor

tobibeer commented Dec 7, 2017 •
edited

@donleyp: I made a PR to fix this: #3042 . Perhaps close, since the initial commit was also heavily commented.

@donleyp donleyp closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sukima @tobibeer @Arlen22 @donleyp