-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTML5 attributes support to the EditText widget #4230
Comments
I believe this is covered by the rangewidget |
@Jermolene which would be more appropriate here if I may ask? A commit to the core, or a plugin commit to address this issue? |
@twMat that widget only applies to range type and not number type input. Since this deals with numbers in a text field, it would be more appropriate for the edit - text widget. |
@twMat and of course, there are still many relevant but unsupported attributes to consider besides those listed e.g. Pattern. |
@Jermolene glad you agree. However, to reiterate my point, range input does not mean much for the number type input. It only applies to the range input. So we should also consider supporting |
Even I had forgotten about the range widget 😅 |
Hi @abesamma at the moment we generally use a separate widget for each type variant of the "input" element. The edit text widget when used with So, I think I'd favour exposing |
I think that's a good idea, but I thought edit-text was designed to support the number input as well, given that the original widget as it is responds to the input type Anyway, if that is the convention, then there is a lot to implement, given the sheer variety of input types and their respective attributes. And a lot of them already have broad support currently. |
I use the edit text widget in a new project and it produces an input of type number as expected. Just without the necessary config options mentioned in the OP. The documentation made not clear for me, that the type attribute would be restricted to "text". It says:
And in the table, the explication for the type attribute is:
So "number" seemed to be a valid type. If this is not the case, I would suggest to make the docs clearer. Is there any hope that we get a widget for inputs of the type number soon? |
Issue:
EditText
widget currently does not support common, and important HTML5 attributes such as:Proposed solution: Pull request to add support via
factory.js
forEditText
widget, andsimple.js
toolbar engine files.Here's a demo of the plugin I've created that adds 3 of these attributes to a seperate
EditTextPlus
widget. Works exactly the same way as the nativeEditText
widget, but with a different name.The text was updated successfully, but these errors were encountered: