Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IDEA] Menu bar plugin Page controls: Save changes to indicate unsaved changes (color) #6832

Closed
nicolnt opened this issue Jul 27, 2022 · 4 comments

Comments

@nicolnt
Copy link

nicolnt commented Jul 27, 2022

Is your feature request related to a problem? Please describe.
I regret that in the "Page controls" option in the Menu bar plugin it doesn't change the "Save changes" icon color like TW does in the default toolbar.

Default TW toolbar when some changes are not saved
image

Default Menu bar Page controls even when some changes are not saved
image

Describe the solution you'd like
Change icon color when some changes need to be saved
image

@Jermolene
Copy link
Owner

Thank you @nicolnt, good catch. Fix is coming up momentarily.

@Jermolene
Copy link
Owner

The fix will be part of the next release, but you can preview it as part of the prerelease here:

https://tiddlywiki.com/prerelease/

(It will take approximately 10 minutes to rebuild as I write this)

@nicolnt
Copy link
Author

nicolnt commented Jul 28, 2022

The fix will be part of the next release

I didn't expect it to be fixed that fast, you rock!

@Jermolene
Copy link
Owner

I didn't expect it to be fixed that fast, you rock!

Thank you @nicolnt! Happily there's quite a big class of bugs that are just oversights, and relatively straightforward to fix. The tricky thing is identifying them and reporting them, so thank you for that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants