Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Preview broken when $:/config/ShowEditPreview/PerTiddler is set to yes #7893

Closed
yaisog opened this issue Dec 16, 2023 · 4 comments
Closed

Comments

@yaisog
Copy link
Contributor

yaisog commented Dec 16, 2023

Describe the bug

Previews don't work when the above setting is active.
This is likely related to #7747. The qualify macro results are not correct now that is has been moved into $:/core/ui/EditorToolbar/preview, so the wrong state tiddler is set.

Expected behavior

No response

To Reproduce

  1. Go to tiddlywiki.com
  2. Enable the per-tiddler preview state
  3. Edit a tiddler and turn on preview
  4. See error

Screenshots

No response

TiddlyWiki Configuration

v5.3.2

Additional context

No response

@Jermolene
Copy link
Owner

Thanks @yaisog – would you be able to have a look at this @BurningTreeC?

@AnthonyMuscio
Copy link
Contributor

Possibly related to this is when the above is set to no or deleted, the preview works, however with both the "widget Tree Preview" and "Raw HTML" preview you can't see the edit panel and the previews are full width.

  • I think there is a bug in the flex box, or columns for different screen sizes.

I am glad to know this bug exits, but it is quite substantial, so can we post about in talk.tiddlywiki and if possible, provide a temporary patch?

I wasted hours going crazy by working on a set of advanced previews and thought I was going crazy with all sorts of weird behaviours not knowing it was not me, it was tiddlywiki.

Just now I noticed another bug;

  • Open $:/core/ui/EditorToolbar/preview
  • Open the preview and select RAW Html
  • Resize the browser window to get the preview along side the editor
  • I get the result below in FireFox , the preview is an HTML version of a SVG not the HTML of the content in the editor.

Snag_1ddca396

@pmario
Copy link
Contributor

pmario commented Dec 21, 2023

@yaisog -- IMO we can close this one. The PR has been merged

@yaisog yaisog closed this as completed Dec 21, 2023
@AnthonyMuscio
Copy link
Contributor

Possibly related to this is when the above is set to no or deleted, the preview works, however with both the "widget Tree Preview" and "Raw HTML" preview you can't see the edit panel and the previews are full width.

I can confirm the full screen and column issues are now resolved ion the pre-release, I can also see, given the tiddler was a button the html does naturally resolve to an SVG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants