Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signing CLA #8307

Conversation

springerspandrel
Copy link
Contributor

Signing CLA


Submitted using https://saqimtiaz.github.io/tw5-docs-pr-maker/.

Copy link

vercel bot commented Jun 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tiddlywiki5 ✅ Ready (Inspect) Visit Preview Jun 27, 2024 7:53pm

@pmario
Copy link
Member

pmario commented Jun 28, 2024

@springerspandrel Signing the CLA is only needed once

@pmario
Copy link
Member

pmario commented Jun 28, 2024

@Jermolene -- You should merge the pending CLAs, otherwise the doc-pr-maker will request them everytime it checks for missing CLAs

@Jermolene
Copy link
Member

Thanks @springerspandrel

@Jermolene Jermolene merged commit 0f4bc93 into TiddlyWiki:tiddlywiki-com Jun 28, 2024
2 checks passed
@pmario
Copy link
Member

pmario commented Jun 28, 2024

@springerspandrel -- You can close your duplicate CLA signatures now - Thx for your engagement also at Talk - o7

@springerspandrel
Copy link
Contributor Author

I'm afraid I have no idea where the multiple CLAs exist such that I could close the duplicates... (The pr-maker prompted me to reload before starting a new issue, and reloading prompts the tour again, all the way through the CLA step. In future I'll just close the tour. But if the CLA is somewhere accessible, perhaps the presence of a signed CLA could be checked-for, and the tour would not prompt again?)

@saqimtiaz
Copy link
Member

@springerspandrel below are the links for the extraneous CLA signature PRs.

The PR maker does indeed check if the CLA has been signed and if so skips that step. However, it has no means to know if a CLA signature has been submitted (as a PR) and not yet accepted, which led to the duplication in this case. So you should not face this issue again now that your signature submission has been accepted, and should indeed reload the wiki before starting a new submission.

Duplicate CLA signature PRs that can be closed.

@pmario
Copy link
Member

pmario commented Jun 28, 2024

The Pullrequests overview offers a nice filter for your own PRs
The same thing also works for issues you created

author:springerspandrel ... filters for you as an author - So you started the issue, PR, discussion
commenter:springerspandrel ... only shows issue, PR, discussions where you added a comment (IMO that's very handy)

Also see: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-author
or: https://docs.github.com/en/search-github/searching-on-github/searching-issues-and-pull-requests#search-by-commenter

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants