Skip to content
This repository has been archived by the owner on Jan 9, 2019. It is now read-only.

wrong files from composer #4

Closed
brianally opened this issue Sep 16, 2017 · 5 comments
Closed

wrong files from composer #4

brianally opened this issue Sep 16, 2017 · 5 comments

Comments

@brianally
Copy link

brianally commented Sep 16, 2017

I'm not sure how to explain this. I ran:

composer require jeroen-g/laravel-pages

That gave an error because of the dependency on cocur/slugify@master-dev
I then added that package as a dependency and ran the above again. My composer.json now has "jeroen-g/laravel-pages": "^2.0", but the files themselves do not reflect the latest changes in master. Specifically, the changes made to fix bugs #1 & #2.

I don't know enough about composer to say for sure but it seems like this package is not in sync with it. (I did not have an old version cached locally.)

However, as i said, my composer.json now claims that i have 2.0 installed. Go figure.

When i cloned the repo directly, of course, all was fine.

I forgot to note the version of composer itself (work machine) but i'm pretty sure it's up to date. I can let you know monday.

@Jeroen-G
Copy link
Owner

Which version of Laravel?

@brianally
Copy link
Author

5.4 and PHP 7.1

@Jeroen-G
Copy link
Owner

Could you test with "jeroen-g/laravel-pages": "dev-master"?
If it works (it should, the tests pass), I'll make a new release.

@brianally
Copy link
Author

That worked. Files up to date.

@Jeroen-G
Copy link
Owner

Tagged as version 3.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants