Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make diststats compatible with non-uniform P(r) #92

Closed
luisfabib opened this issue Mar 16, 2021 · 0 comments · Fixed by #94
Closed

Make diststats compatible with non-uniform P(r) #92

luisfabib opened this issue Mar 16, 2021 · 0 comments · Fixed by #94
Labels
enhancement New feature or request
Milestone

Comments

@luisfabib
Copy link
Member

Most of the quantities calculated in diststats are based on moment analysis. However, the integration is mostly done using a simple summation

# Expectation operator function
def E(x,P):
    return np.sum(x*P/np.sum(P))

instead of trapezoidal integration, etc. This will return incorrect results when passing non-uniformly defined distance distributions.

Is not urgent, or difficult, but should be adapted to some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants