Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

width in Gaussian distribution models #278

Closed
stestoll opened this issue Mar 8, 2022 · 1 comment · Fixed by #280
Closed

width in Gaussian distribution models #278

stestoll opened this issue Mar 8, 2022 · 1 comment · Fixed by #280
Labels
design
Milestone
0.14.0

Comments

@stestoll
Copy link
Collaborator

stestoll commented Mar 8, 2022 •
edited

Consider

P = dl.dd_gauss(r, mean=3.5, width=0.2)

It is not clear whether width refers to the full-width-at-half-maximum, the standard deviation, or another width measure. As implemented, it is the standard deviation. Therefore, I suggest renaming it to stdev or std.
@stestoll stestoll added the design label Mar 8, 2022
@stestoll stestoll added this to the 0.14.0 milestone Mar 8, 2022
@stestoll
Copy link
Collaborator Author

stestoll commented Mar 9, 2022

Maybe std for consistency with whitegaussiannoise.

@stestoll stestoll linked a pull request Mar 10, 2022 that will close this issue
gauss: change width to std #280
Merged
3 tasks
@stestoll stestoll mentioned this issue Mar 10, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design
Projects
None yet
Milestone
0.14.0
Development

Successfully merging a pull request may close this issue.

gauss: change width to std JeschkeLab/DeerLab
1 participant
@stestoll