Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/Revamp Macro Support #13

Open
JesseCoretta opened this issue Jul 18, 2022 · 1 comment · May be fixed by #16
Open

Improve/Revamp Macro Support #13

JesseCoretta opened this issue Jul 18, 2022 · 1 comment · May be fixed by #16
Assignees
Labels
enhancement New feature or request V2 schemax v2.0.0

Comments

@JesseCoretta
Copy link
Owner

Describe the solution you'd like
Macros support is sloppy and implemented almost as an afterthought. It should be revamped in a manner similar to the Extension redesign, which discontinued use of map[string][]string types in favor of proper collection types.

Describe alternatives you've considered
Simply not using Macros will work most of the time, however certain RFCs, such as RFC2307, do require basic Alias-To-OID resolution for certain definitions during the Marshal (parsing) process. Therefore, outright abandoning macro support is not feasible ... its here to stay.

Leaving the current solution as it is would be fine too, but a revamp certainly couldn't hurt.

@JesseCoretta JesseCoretta self-assigned this Jul 28, 2022
@JesseCoretta JesseCoretta added the enhancement New feature or request label Jul 28, 2022
@JesseCoretta JesseCoretta added the wontfix This will not be worked on label Oct 20, 2023
@JesseCoretta
Copy link
Owner Author

Implemented by #16

@JesseCoretta JesseCoretta linked a pull request Jun 17, 2024 that will close this issue
@JesseCoretta JesseCoretta linked a pull request Jun 17, 2024 that will close this issue
@JesseCoretta JesseCoretta added V2 schemax v2.0.0 and removed wontfix This will not be worked on labels Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request V2 schemax v2.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant