Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hijri Date #8

Closed
hjcccompany opened this issue Nov 30, 2018 · 6 comments
Closed

Hijri Date #8

hjcccompany opened this issue Nov 30, 2018 · 6 comments

Comments

@hjcccompany
Copy link

I have rarely coded in python, so that's why I can't help you right now in codes.
The problem here goes in the Hijri date, even with that Algorithm it sometimes goes wrong for example by one day missing.

I think adding the option for that day in the options menu will help a lot.

Thanks for your work, I really like the app, and I will soon Inshaa Allah help you improving it.
Omar E.

@AXeL-dev
Copy link
Contributor

AXeL-dev commented Dec 2, 2018

Hey,

it will be more useful if you can provide some screenshots with the steps you have done so i/we can reproduce the issue, for example: where the issue happens exactly? in which month? ..

I think adding the option for that day in the options menu will help a lot.

well, we need to investigate first about the reason of the issue, then we may take a decision about how to fix it x).

Finally, you're welcome.

@hjcccompany
Copy link
Author

like for example today date is wrong, its 26/03/1440 but in the SIlaty software its past a day (25/03) you can check that.

@hjcccompany
Copy link
Author

to explain more,
We are working with moon date(s) not Sun date(s), so there is 2 solutions I think.

  1. Is to make it like prayer time, get (sync) it from internet
    2)Make an option to correct date if its wrong by 1 day + or -.

and thanks a lot for what you did, this app helped me a lot.
May Allah make it in your rewards brother

@AXeL-dev
Copy link
Contributor

AXeL-dev commented Dec 4, 2018

Inshalah x).

Also, i'm okay with the second solution because it seems more easy to implement, i guess.

There is also a fast solution by modifying the value in the line below to 227014, which will add one day to the hijri calendar

__hijri_epoch=227015; # = Julian 0622-7-16 = gregorian 0759-6-11 (I think it should be 622, 7, 19)

unfortunately this value seems to be constant so i'll keep thinking about how to implement the +/-1 day option..

@hjcccompany
Copy link
Author

or don't worry, I will do it soon when I got some time : ) , and make a pull request
جزاك الله خيرا

@AXeL-dev
Copy link
Contributor

AXeL-dev commented Dec 5, 2018

fixed on 4f7f462

You can test it using my fork https://github.com/AXeL-dev/Silaty

P.S.: the debian package is not yet updated so you may need to Install it from source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants