Hide top-level dialog from the taskbar #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swing has a special constructor for that (without arguments). It says:
```
A shared, hidden frame will be set as the owner of the dialog.
```
We need exactly this as a default behaviour for top-level Dialog's. This will hide the icon in the taskbar. If the user need to show icon in the taskbar, Window is a better option.
If `SwingUtilities.getSharedOwnerFrame()` was public, I would just use it as a default value in the constructor, but instead we have to create a separate constructor and keep it consistent with JDialog, even if it is unusual API.
The reproducer:
```
import androidx.compose.ui.awt.ComposeDialog
import javax.swing.SwingUtilities
fun main() = SwingUtilities.invokeLater {
val dialog = ComposeDialog()
dialog.setSize(800, 600)
dialog.isVisible = true
}
```
The icon shouldn't be in the taskbar now.
olonho
approved these changes
Feb 2, 2022
Rsedaikin
approved these changes
Feb 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swing has a special constructor for that (without arguments). It says:
We need exactly this as a default behaviour for top-level Dialog's. This will hide the icon in the taskbar. If the user need to show icon in the taskbar, Window is a better option.
If
SwingUtilities.getSharedOwnerFrame()was public, I would just use it as a default value in the constructor, but instead we have to create a separate constructor and keep it consistent withJDialog, even if it is unusual API.The reproducer:
The icon shouldn't be in the taskbar now.
Old behavior:
New behavior:
