Focus Swing interop. Move focus from Compose to SwingPanel #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
force-pushed
the
feature/focusInterop4
branch
from
bdeb649
to
5d7318c
Compare
igordmn
force-pushed
the
feature/focusInterop3
branch
from
42b3469
to
bb9d710
Compare
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/awt/SwingPanel.desktop.kt
Show resolved
Hide resolved
dima-avdeev-jb
approved these changes
May 31, 2022
igordmn
force-pushed
the
feature/focusInterop3
branch
2 times, most recently
from
6004380
to
d79dc50
Compare
Also added tests for all focus interop cases.
igordmn
force-pushed
the
feature/focusInterop4
branch
from
5d7318c
to
3f04d92
Compare
eymar
pushed a commit
that referenced
this pull request
Jun 27, 2022
* Focus Swing interop. Move focus from Compose to SwingPanel Also added tests for all focus interop cases. * fix SAM crash in Layout measurePolicy with value class, fix run3 * Refactor * Disable tests for macOs
eymar
pushed a commit
that referenced
this pull request
Jun 28, 2022
* Focus Swing interop. Move focus from Compose to SwingPanel Also added tests for all focus interop cases. * fix SAM crash in Layout measurePolicy with value class, fix run3 * Refactor * Disable tests for macOs
igordmn
added a commit
that referenced
this pull request
Aug 18, 2022
* Focus Swing interop. Move focus from Compose to SwingPanel Also added tests for all focus interop cases. * fix SAM crash in Layout measurePolicy with value class, fix run3 * Refactor * Disable tests for macOs
igordmn
added a commit
that referenced
this pull request
Aug 18, 2022
* Focus Swing interop. Move focus from Compose to SwingPanel Also added tests for all focus interop cases. * fix SAM crash in Layout measurePolicy with value class, fix run3 * Refactor * Disable tests for macOs
This was referenced Aug 22, 2022
Merged
Merged
eymar
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Focus Swing interop. Move focus from Compose to SwingPanel Also added tests for all focus interop cases. * fix SAM crash in Layout measurePolicy with value class, fix run3 * Refactor * Disable tests for macOs
eymar
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Focus Swing interop. Move focus from Compose to SwingPanel Also added tests for all focus interop cases. * fix SAM crash in Layout measurePolicy with value class, fix run3 * Refactor * Disable tests for macOs
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Focus Swing interop. Move focus from Compose to SwingPanel Also added tests for all focus interop cases. * fix SAM crash in Layout measurePolicy with value class, fix run3 * Refactor * Disable tests for macOs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compose doesn't support detecting from where we receive the focus (from the previous or from the next component). But we need to know it, so we can focus the first or the last component in SwingPanel. We create two empty Compose components to do that (if we focused on the first component - it means the focus came from the previous one).
Also added tests for all focus interop cases. On macOs the tests are disabled