fix pointerHoverIcon: update icon when it's changed conditionally #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Jun 6, 2022
| // Create and chain a new instance of a dumbModifier for every new icon. | ||
| // This forces the LayoutNode to requestRelayout, leading to a synthetic event being dispatched | ||
| // and then handled here in pointerInput below, and then applying the icon to the pointerIconService. | ||
| val dumbModifier = remember(icon) { object : Modifier.Element {} } |
There was a problem hiding this comment.
This uses implementation details of the how relayout happens. In the future there can be an optimisation to not perform relayout on new empty modifiers.
What if we tell explicitly, that we need a new synthetic event?
SideEffect {
pointerIconService.refresh()
}
override val pointerIconService = object : PointerIconService {
override var current: PointerIcon = PointerIconDefaults.Default
fun refresh() = pointerPositionUpdater.onLayout() // better to rename onLayout to `needUpdate`, because now we call it not only on layout
}
Also, if it is not complicated, better to write a test to this behaviour.
There was a problem hiding this comment.
done.
I decided to use DisposableEffect(key = icon) instead of a SideEffect, to avoid requesting the update for every recomposition.
We also can add DisposableEffect conditionally: only when a component is hovered: if (isHovered) DisapobleEffect.
There was a problem hiding this comment.
We also can add DisposableEffect conditionally: only when a component is hovered: if (isHovered) DisapobleEffect.
Great idea ). Let's do this way
igordmn
approved these changes
Jun 7, 2022
eymar
added a commit
that referenced
this pull request
Jun 27, 2022
* fix pointerHoverIcon: update icon when it's changed conditionally JetBrains/compose-multiplatform#2091 * add tests * add DisposableEffect conditionally - only when a component is hovered Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Jun 28, 2022
* fix pointerHoverIcon: update icon when it's changed conditionally JetBrains/compose-multiplatform#2091 * add tests * add DisposableEffect conditionally - only when a component is hovered Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
* fix pointerHoverIcon: update icon when it's changed conditionally JetBrains/compose-multiplatform#2091 * add tests * add DisposableEffect conditionally - only when a component is hovered Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
* fix pointerHoverIcon: update icon when it's changed conditionally JetBrains/compose-multiplatform#2091 * add tests * add DisposableEffect conditionally - only when a component is hovered Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Oct 26, 2022
* fix pointerHoverIcon: update icon when it's changed conditionally JetBrains/compose-multiplatform#2091 * add tests * add DisposableEffect conditionally - only when a component is hovered Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Nov 16, 2022
* fix pointerHoverIcon: update icon when it's changed conditionally JetBrains/compose-multiplatform#2091 * add tests * add DisposableEffect conditionally - only when a component is hovered Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Jan 13, 2023
* fix pointerHoverIcon: update icon when it's changed conditionally JetBrains/compose-multiplatform#2091 * add tests * add DisposableEffect conditionally - only when a component is hovered Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes JetBrains/compose-multiplatform#2091