fix DesktopMenu and DesktopAlertDialog to invoke dismiss callback once #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I plan to add some tests for onDismissRequest callback and ESC after #255 is merged |
igordmn
approved these changes
Jul 20, 2022
added 2 commits
July 20, 2022 15:28
…e on ESC keyDown It used to invoke it twice: on KeyDown and then on KeyUp
eymar
force-pushed
the
fix_dismiss_popup_on_esc
branch
from
a80c1c6
to
f63f1e3
Compare
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
#256) * fix DesktopMenu and DesktopAlertDialog to invoke dismiss callback once on ESC keyDown It used to invoke it twice: on KeyDown and then on KeyUp * add tests Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
#256) * fix DesktopMenu and DesktopAlertDialog to invoke dismiss callback once on ESC keyDown It used to invoke it twice: on KeyDown and then on KeyUp * add tests Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Oct 26, 2022
#256) * fix DesktopMenu and DesktopAlertDialog to invoke dismiss callback once on ESC keyDown It used to invoke it twice: on KeyDown and then on KeyUp * add tests Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Nov 16, 2022
#256) * fix DesktopMenu and DesktopAlertDialog to invoke dismiss callback once on ESC keyDown It used to invoke it twice: on KeyDown and then on KeyUp * add tests Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Jan 13, 2023
#256) * fix DesktopMenu and DesktopAlertDialog to invoke dismiss callback once on ESC keyDown It used to invoke it twice: on KeyDown and then on KeyUp * add tests Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix DesktopMenu and DesktopAlertDialog to invoke dismiss callback once on ESC keyDown
It used to invoke it twice: on KeyDown and then on KeyUp