forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
navigate drop down menu items using up and down arrows #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
91b0c85
to
19da3ec
Compare
igordmn
reviewed
Jul 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I thought that we didn't have this feature at all, but it seems all we need to do is a slightly improvement :)
...se/material/material/src/desktopMain/kotlin/androidx/compose/material/DesktopMenu.desktop.kt
Outdated
Show resolved
Hide resolved
...se/material/material/src/desktopMain/kotlin/androidx/compose/material/DesktopMenu.desktop.kt
Outdated
Show resolved
Hide resolved
igordmn
reviewed
Jul 22, 2022
...se/material/material/src/desktopMain/kotlin/androidx/compose/material/DesktopMenu.desktop.kt
Outdated
Show resolved
Hide resolved
19da3ec
to
004ee0a
Compare
igordmn
approved these changes
Jul 25, 2022
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
* navigate drop down menu items using up and down arrows * refactoring * Allow arrows navigation within a context menu (On a TextField) * add a test for arrows navigation in DropDownMenu Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
pushed a commit
that referenced
this pull request
Aug 18, 2022
* navigate drop down menu items using up and down arrows * refactoring * Allow arrows navigation within a context menu (On a TextField) * add a test for arrows navigation in DropDownMenu Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Oct 26, 2022
* navigate drop down menu items using up and down arrows * refactoring * Allow arrows navigation within a context menu (On a TextField) * add a test for arrows navigation in DropDownMenu Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Nov 16, 2022
* navigate drop down menu items using up and down arrows * refactoring * Allow arrows navigation within a context menu (On a TextField) * add a test for arrows navigation in DropDownMenu Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
added a commit
that referenced
this pull request
Jan 13, 2023
* navigate drop down menu items using up and down arrows * refactoring * Allow arrows navigation within a context menu (On a TextField) * add a test for arrows navigation in DropDownMenu Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When DropDownMenu/CursorDropdownMenu or ContextMenu (on TextField) pops up, the menu items can be navigated using Up and Down arrows.