Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigate drop down menu items using up and down arrows #259

Merged
merged 4 commits into from
Jul 26, 2022

Conversation

eymar
Copy link
Collaborator

@eymar eymar commented Jul 21, 2022

When DropDownMenu/CursorDropdownMenu or ContextMenu (on TextField) pops up, the menu items can be navigated using Up and Down arrows.

@eymar eymar force-pushed the dropdown_menu_item_focusable_by_arrows branch from 91b0c85 to 19da3ec Compare July 21, 2022 08:49
Copy link
Collaborator

@igordmn igordmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I thought that we didn't have this feature at all, but it seems all we need to do is a slightly improvement :)

@eymar eymar force-pushed the dropdown_menu_item_focusable_by_arrows branch from 19da3ec to 004ee0a Compare July 25, 2022 13:39
@eymar eymar merged commit df48253 into jb-main Jul 26, 2022
@eymar eymar deleted the dropdown_menu_item_focusable_by_arrows branch July 26, 2022 10:00
igordmn pushed a commit that referenced this pull request Aug 18, 2022
* navigate drop down menu items using up and down arrows

* refactoring

* Allow arrows navigation within a context menu (On a TextField)

* add a test for arrows navigation in DropDownMenu

Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn pushed a commit that referenced this pull request Aug 18, 2022
* navigate drop down menu items using up and down arrows

* refactoring

* Allow arrows navigation within a context menu (On a TextField)

* add a test for arrows navigation in DropDownMenu

Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar added a commit that referenced this pull request Oct 26, 2022
* navigate drop down menu items using up and down arrows

* refactoring

* Allow arrows navigation within a context menu (On a TextField)

* add a test for arrows navigation in DropDownMenu

Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar added a commit that referenced this pull request Nov 16, 2022
* navigate drop down menu items using up and down arrows

* refactoring

* Allow arrows navigation within a context menu (On a TextField)

* add a test for arrows navigation in DropDownMenu

Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar added a commit that referenced this pull request Jan 13, 2023
* navigate drop down menu items using up and down arrows

* refactoring

* Allow arrows navigation within a context menu (On a TextField)

* add a test for arrows navigation in DropDownMenu

Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants