Toggle on space key #262
Merged
Toggle on space key #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igordmn
reviewed
Jul 26, 2022
...ndation/foundation/src/commonMain/kotlin/androidx/compose/foundation/selection/Toggleable.kt
Outdated
Show resolved
Hide resolved
eymar
force-pushed
the
toggle_on_space_key
branch
from
0755cfe
to
e9b6d8d
Compare
igordmn
approved these changes
Jul 27, 2022
igordmn
added a commit
that referenced
this pull request
Aug 18, 2022
* Perform toggle on Space key Similar to https://android-review.googlesource.com/c/platform/frameworks/support/+/1858797 * add a test for toggleable to toggle by Space button * add Toggleable.jsNative.kt with `isToggle` actual Co-authored-by: Igor Demin <igordmn@gmail.com> Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
added a commit
that referenced
this pull request
Aug 18, 2022
* Perform toggle on Space key Similar to https://android-review.googlesource.com/c/platform/frameworks/support/+/1858797 * add a test for toggleable to toggle by Space button * add Toggleable.jsNative.kt with `isToggle` actual Co-authored-by: Igor Demin <igordmn@gmail.com> Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Perform toggle on Space key Similar to https://android-review.googlesource.com/c/platform/frameworks/support/+/1858797 * add a test for toggleable to toggle by Space button * add Toggleable.jsNative.kt with `isToggle` actual Co-authored-by: Igor Demin <igordmn@gmail.com> Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Perform toggle on Space key Similar to https://android-review.googlesource.com/c/platform/frameworks/support/+/1858797 * add a test for toggleable to toggle by Space button * add Toggleable.jsNative.kt with `isToggle` actual Co-authored-by: Igor Demin <igordmn@gmail.com> Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Perform toggle on Space key Similar to https://android-review.googlesource.com/c/platform/frameworks/support/+/1858797 * add a test for toggleable to toggle by Space button * add Toggleable.jsNative.kt with `isToggle` actual Co-authored-by: Igor Demin <igordmn@gmail.com> Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
added a commit
that referenced
this pull request
Nov 15, 2023
* Perform toggle on Space key Similar to https://android-review.googlesource.com/c/platform/frameworks/support/+/1858797 * add a test for toggleable to toggle by Space button * add Toggleable.jsNative.kt with `isToggle` actual Co-authored-by: Igor Demin <igordmn@gmail.com> Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
igordmn
added a commit
that referenced
this pull request
Nov 16, 2023
* Perform toggle on Space key Similar to https://android-review.googlesource.com/c/platform/frameworks/support/+/1858797 * add a test for toggleable to toggle by Space button * add Toggleable.jsNative.kt with `isToggle` actual Co-authored-by: Igor Demin <igordmn@gmail.com> Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a replacement for #126 (the #126 was not possible to rebase on top of jb-main, because that PR was based on a different branch - release/1.0)
This PR adds some changes to the original one: