Fix cursor visual position at BiDi transition #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
changed the title
dima-avdeev-jb
approved these changes
Sep 1, 2022
igordmn
approved these changes
Sep 1, 2022
eymar
pushed a commit
that referenced
this pull request
Oct 26, 2022
* Fix cursor position in RTL text on line transition * amend * improved solution (to cover not only new lines)
eymar
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Fix cursor position in RTL text on line transition * amend * improved solution (to cover not only new lines)
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
* Fix cursor position in RTL text on line transition * amend * improved solution (to cover not only new lines)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue description:
When cursor is at BiDi transition position, its visual position doesn't correspond the real (logical) position, leading to a confusion when we try to type more characters (new characters appear at different position than the cursor).
bidi_transition_rtl_primary_bug.mov
With this Fix:
https://user-images.githubusercontent.com/7372778/187870680-fd23ec2a-e60a-4b65-b1d3-5dc31dc0f996.mov