forked from androidx/androidx
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default Font on MacOs to San Francisco #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
approved these changes
Sep 14, 2022
eymar
pushed a commit
that referenced
this pull request
Oct 26, 2022
eymar
pushed a commit
that referenced
this pull request
Nov 16, 2022
igordmn
added a commit
that referenced
this pull request
Dec 5, 2022
In #296 I accidentally pushed the wrong fix, which doesn't work. Thanks Alexander Maryanovsky pointed at this [here](https://kotlinlang.slack.com/archives/C01D6HTPATV/p1670249182045759?thread_ts=1669996652.181129&cid=C01D6HTPATV)
igordmn
added a commit
that referenced
this pull request
Dec 5, 2022
In #296 I accidentally pushed the wrong fix, which doesn't work. Thanks Alexander Maryanovsky pointed at this [here](https://kotlinlang.slack.com/archives/C01D6HTPATV/p1670249182045759?thread_ts=1669996652.181129&cid=C01D6HTPATV)
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
In #296 I accidentally pushed the wrong fix, which doesn't work. Thanks Alexander Maryanovsky pointed at this [here](https://kotlinlang.slack.com/archives/C01D6HTPATV/p1670249182045759?thread_ts=1669996652.181129&cid=C01D6HTPATV)
MatkovIvan
pushed a commit
to MatkovIvan/compose-multiplatform
that referenced
this pull request
May 10, 2023
In JetBrains/compose-multiplatform-core#296 I accidentally pushed the wrong fix, which doesn't work. Thanks Alexander Maryanovsky pointed at this [here](https://kotlinlang.slack.com/archives/C01D6HTPATV/p1670249182045759?thread_ts=1669996652.181129&cid=C01D6HTPATV)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a default font for UI in macOS. Introduced a lot of versions ago.
(on this screenshot ' symbol is different, not sure why. Maybe in the new version of the font it is different)
Old:
![image](https://user-images.githubusercontent.com/5963351/190037700-d007f175-733e-4041-bcaa-e6d4a1fa322d.png)
![image](https://user-images.githubusercontent.com/5963351/190037361-d4f1a5c2-d5ca-43d3-b4cb-c2baca232e5b.png)
New:
It is not allowed to use San Francisco directly. We should use "system" alias, that can point to a new font in the future.