Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop AlertDialog scrim color #358

Merged

Conversation

dima-avdeev-jb
Copy link

@dima-avdeev-jb dima-avdeev-jb commented Jan 1, 2023

Fix JetBrains/compose-multiplatform#2580
In android Dialog shows with scrim color.
image

In Desktop, for now we don't have scrim:
image

But, this PR adds scrim:
image

Also, add temporary PopupDialog. In the future, it should be changed to LayerDialog.(JetBrains/compose-multiplatform#933)

JetBrains/compose-multiplatform#2580
Also, add temporary PopupDialog. In the future it should be changed to LayerDialog.(JetBrains/compose-multiplatform#933)
@dima-avdeev-jb dima-avdeev-jb merged commit a9f8345 into jb-main Jan 5, 2023
@dima-avdeev-jb dima-avdeev-jb deleted the dima-avdeev/Issue-2580-desktop-alert-dialog-scrim branch January 5, 2023 14:58
eymar pushed a commit that referenced this pull request Jan 13, 2023
JetBrains/compose-multiplatform#2580
Also, add temporary PopupDialog. In the future, it should be changed to LayerDialog.(JetBrains/compose-multiplatform#933)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants