Skip to content
This repository has been archived by the owner on Jul 13, 2020. It is now read-only.

Some fixes #42

Merged
merged 3 commits into from
May 25, 2015
Merged

Some fixes #42

merged 3 commits into from
May 25, 2015

Conversation

lucky-dev
Copy link
Contributor

  1. (Commit 1) The method "startService" was added to Context. It gives opportunity to write code like this:
context.startService<MyService>("id" to 1)
  1. (Commit 2) I found this bug:
E/SQLiteLog﹕ (1) AUTOINCREMENT is only allowed on an INTEGER PRIMARY KEY

when I was creating a table

createTable(MyTable.NAME, false,
                        MyTable.Column.ID to INT + PRIMARY_KEY + AUTOINCREMENT,
                        MyTable.Column.NAME to TEXT)

@lucky-dev lucky-dev changed the title Method "startService" was added Some fixes May 18, 2015
@yanex
Copy link
Member

yanex commented May 25, 2015

Thank you for the pull request!

  1. Maybe Fragment should then have startService() function as well. Please look into the ContextUtils.kt and Support.kt files.
  2. This change breaks existing code. You can annotate the old val with deprecated (there's an example: https://github.com/JetBrains/kotlin/blob/master/libraries/stdlib/src/kotlin/collections/Sequence.kt#L307).

@lucky-dev
Copy link
Contributor Author

Thanks for your reply. I updated my pull request.

yanex added a commit that referenced this pull request May 25, 2015
startService() method, INTEGER SQL column type
@yanex yanex merged commit d8249cc into Kotlin:master May 25, 2015
@yanex
Copy link
Member

yanex commented May 25, 2015

Merged!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants