Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server assumes only scala_test targets - more flexibility needed #96

Closed
1 of 2 tasks
abrams27 opened this issue Sep 6, 2021 · 6 comments
Closed
1 of 2 tasks
Labels
enhancement New feature or request moved to youtrack

Comments

@abrams27
Copy link
Member

abrams27 commented Sep 6, 2021

ScalaBuildServerService assumes only scala_test targets. Rules Scala has support for scala junit tests and Specs2 support is added via that rule: https://github.com/bazelbuild/rules_scala/blob/master/scala/scala.bzl#L38 - we need to support it as well

things to do:

  • EASY - include such targets in the BSP project
  • HARD - include test classes in the BSP - we need to figure out how to obtain such information from test discovery mechanism
@abrams27
Copy link
Member Author

easy part done in #101

@ittaiz
Copy link

ittaiz commented Oct 20, 2021

re hard part- do you have any thoughts? do you need more info on how the mechanism works?
[Context- I wrote the rules_scala junit discovery mechanism]

@abrams27
Copy link
Member Author

hi! thank you for contact.
the main concern is whether it is possible to obtain an information about tests main classes without executing them? in our server we need to return such information to the client. One solution is simply implementing a test discovery mechanism on our side, but it seems a bit wrong.

@ittaiz
Copy link

ittaiz commented Oct 22, 2021

Few questions:

  1. Why is this needed?
  2. Can this be iterative and while they're being executed?
  3. How cheap/costly should/can this be?

@abrams27
Copy link
Member Author

  1. Why is this needed?

bsp specification - this information might be useful for a client to for example display run test icon.

  1. Can this be iterative and while they're being executed?

this information is usually fetched during importing - after that a client can use this information to ask server to execute a given test

  1. How cheap/costly should/can this be?

well, as least costly as possible - there are endpoints that build the project, which could potentially be very costly. So, I believe that building is a limit - so executing tests isn't an option

@abrams27
Copy link
Member Author

first point done, second moved: https://youtrack.jetbrains.com/issue/BAZEL-41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request moved to youtrack
Projects
None yet
Development

No branches or pull requests

2 participants