Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use icon defined in build.gradle as the taskbar icon (macOs) #1342

Closed
igordmn opened this issue Nov 1, 2021 · 1 comment · Fixed by #1386
Closed

Use icon defined in build.gradle as the taskbar icon (macOs) #1342

igordmn opened this issue Nov 1, 2021 · 1 comment · Fixed by #1386
Assignees
Labels
macos ui glitch Visual glitch in UI, usually not blocking normal usage
Milestone

Comments

@igordmn
Copy link
Collaborator

igordmn commented Nov 1, 2021

macOs doesn't support icons for individual windows, so when we set icon in singleWindowApplication or in Window, we don't change anything.

To change the icon, we should change it inside build.gradle. It changes the icon for native distribution, but doesn't change it for the debug mode (we have a default java icon).

To fix that, we need to pass this:

jvmArgs("-Xdock:icon=src/jvmMain/resources/ic_launcher.png")

Also, we need to write a warning into the log, if user uses singleWindowApplication(icon= attribute on macOs.

Message in Slack

@igordmn igordmn added ui glitch Visual glitch in UI, usually not blocking normal usage macos p:low labels Nov 1, 2021
@igordmn igordmn self-assigned this Nov 1, 2021
@igordmn igordmn added this to the 1.0 milestone Nov 1, 2021
@igordmn
Copy link
Collaborator Author

igordmn commented Nov 10, 2021

Also, we need to write a warning into the log, if user uses singleWindowApplication(icon= attribute on macOs.

Decided not to write warning into the log, as it pollutes the log with unnecessary information. But added more info about [icon] parameter to KDoc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macos ui glitch Visual glitch in UI, usually not blocking normal usage
Projects
None yet
2 participants