Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crashes when rendering ImageComposeScene #1392

Closed
jimgoog opened this issue Nov 13, 2021 · 1 comment
Closed

Crashes when rendering ImageComposeScene #1392

jimgoog opened this issue Nov 13, 2021 · 1 comment
Assignees
@igordmn
Labels
crash desktop test wait for build

Comments

@jimgoog
Copy link
Collaborator

jimgoog commented Nov 13, 2021

Code in question crashes in a variety of inconsistent ways (core dump, stack traces, native code errors, etc):

fun main() {
    val scene = ImageComposeScene(100, 100) {
        CircularProgressIndicator()
    }
    for (i in 1..10000) {
        scene.render(Duration.milliseconds(i)).close()
    }
}

cc @igordmn
@igordmn igordmn self-assigned this Nov 13, 2021
@jimgoog jimgoog mentioned this issue Nov 13, 2021
Open
@igordmn igordmn added this to the 1.1? milestone Jan 17, 2022
This was referenced Feb 16, 2022
Closed
Merged
@igordmn
Copy link
Collaborator

igordmn commented Feb 27, 2022

Should be fixed in 1.1.0

@igordmn igordmn closed this as completed Feb 27, 2022
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Feb 28, 2022
@igordmn
Fix races with ImageComposeScene
5b46ed0 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 28, 2022
@igordmn
Fix races with ImageComposeScene
6586e32 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Mar 30, 2022
@igordmn
Fix races with ImageComposeScene
a615e7f 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Apr 18, 2022
@igordmn
Fix races with ImageComposeScene
838e0b6 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Jun 2, 2022
@igordmn
Fix races with ImageComposeScene
2719e38 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Jun 27, 2022
@igordmn
Fix races with ImageComposeScene
4100661 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Aug 18, 2022
@igordmn
Fix races with ImageComposeScene
f703cf3 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
igordmn added a commit to JetBrains/compose-multiplatform-core that referenced this issue Aug 18, 2022
@igordmn
Fix races with ImageComposeScene
5d65a2e 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Oct 26, 2022
@igordmn
Fix races with ImageComposeScene
bd6f01e 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Nov 16, 2022
@igordmn @eymar
Fix races with ImageComposeScene
517e275 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
eymar pushed a commit to JetBrains/compose-multiplatform-core that referenced this issue Jan 13, 2023
@igordmn @eymar
Fix races with ImageComposeScene
bb8c705 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains/compose-multiplatform#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
@m-sasha m-sasha mentioned this issue May 6, 2023
Merged
MatkovIvan pushed a commit to MatkovIvan/compose-multiplatform that referenced this issue May 10, 2023
@igordmn @eymar
Fix races with ImageComposeScene
742a5ff 
ImageComposeScene will be introduced in the next commit. It performs in another thread, and have Unconfined coroutine dispatcher. This means all callbacks dispatched to that dispatcher will be performed in the caller thread.

For example, when GlobalSnapshotManager will sendApplyNotifications, all callbacks will be performed in Swing thread, and will race with `render`, which performs in the test thread.

To avoid that, we don't dispatch callback to coroutine dispatcher, instead we use our own dispatching inside ComposeScene via invalidate/render.

Fixes JetBrains#1392

Change-Id: I732b37dd2fa5bb03e7e8f6a001f518199360c9a1
Test: ./gradlew jvmTest desktopTest -Pandroidx.compose.multiplatformEnabled=true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@igordmn igordmn

Labels
crash desktop test wait for build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@igordmn @jimgoog