Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in Todo example app after multiple Compose updates #86

Closed
arkivanov opened this issue Nov 10, 2020 · 5 comments · Fixed by #88
Closed

Regression in Todo example app after multiple Compose updates #86

arkivanov opened this issue Nov 10, 2020 · 5 comments · Fixed by #88
Assignees

Comments

@arkivanov
Copy link
Contributor

There are two issues currently.

Originally the Todo app looked like this:
1

0.1.0-m1-build62 update (3b58367) broke some colors and styles:
2

And the most important is 0.1.0-build113 update (aa2a874). Navigation now does not work, when you click on an item - nothing happens. I tried to debug and found that when the Router applies the new state (with the new child), the view receives old state (with old child).

How to debug the second bug:

  1. Put first breakpoint here
  2. Put second breakpoint here
  3. Click on an item
  4. The first breakpoint will fire and you can observe the new state (it.activeChild ~ Edit)
  5. Continue execution
  6. The second breakpoint will fire and you can observe the old state (state.activeChild ~ Main)

Please let me know if I can help anyhow.

@igordmn igordmn self-assigned this Nov 11, 2020
@arkivanov
Copy link
Contributor Author

Android app also has broken text styles. But navigation works just fine.

@prepor
Copy link
Contributor

prepor commented Nov 11, 2020

It's not broken, the version of Text with previous behavior was moved to androidx.compose.material.Text

@arkivanov
Copy link
Contributor Author

Thanks! I will update Text part tonight. The navigation in desktop still needs to be addressed.

@igordmn
Copy link
Collaborator

igordmn commented Nov 11, 2020

Navigation now does not work

There is a problem in Compose:
#87

And in the example:
#88
(I change imports for Text too :) )

TodoRoot was created two times, and when we click on item - we are using not the right "router".

@arkivanov
Copy link
Contributor Author

Thanks for fixing the issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants