Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CSSVariables context and introduce specialized methods for adding String- and Number-valued CSS variables #894

Closed
Schahen opened this issue Jul 15, 2021 · 0 comments
Closed

Remove CSSVariables context and introduce specialized methods for adding String- and Number-valued CSS variables #894

Schahen opened this issue Jul 15, 2021 · 0 comments
Labels
web
Milestone
CSS API alpha

Comments

@Schahen
Copy link
Collaborator

Schahen commented Jul 15, 2021

The only purpose of CSSVariables interface is to limit the scope of by variable delegation. We've decided that it's totally fine to keep this delegation in global scope and in StyleBuilder scope (where prefix is optionally added - this is the way how it is right now)
@Schahen Schahen added the web label Jul 15, 2021
@Schahen Schahen added this to the CSS API alpha milestone Jul 15, 2021
mareklangiewicz pushed a commit to mareklangiewicz/compose-jb that referenced this issue Feb 14, 2022
@Schahen @mareklangiewicz
Remove CSSVariables context
2277e13 
One can define CSS variables anywhere
This is actually  the only thing we want to do right now in framework
of JetBrains#894

Resolves JetBrains#894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
web
Projects
None yet
Milestone
CSS API alpha
Development

No branches or pull requests
1 participant
@Schahen