-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for transition in CSS api. #2228
Conversation
Hi @Ayfri, Thank you for your contribution! Could you please add unit tests for all new APIs in Also, since this a new API, we usually mark it with P.S. I apologise for a long time without any answer |
web/core/src/jsMain/kotlin/org/jetbrains/compose/web/css/properties/transitions.kt
Show resolved
Hide resolved
I'm creating the unit tests and facing a problem where we have to decide how the API behave : transitions {
duration(1.s)
delay(.5.s)
properties("height", "width")
"width" {
duration(2.s)
}
} Should it returns
Currently, it has the third behavior. |
I think 3rd variant is okay, since it's possible to write such a css manually as well. |
This PR adds a builder to create transitions with the CSS API.