Fix idea plugin compatability #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit db3c1e2.
IDEA doesn't provide backward compatibility policy, and breaking changes can happen in any version, without prior deprecation: https://plugins.jetbrains.com/docs/intellij/api-changes-list.html Because of that, we can't remove `plugin.until.build`, and have to build Compose plugin for each new version of IDEA separately What we should do after that commit, is make sure, that we don't forget to check this compatibility. And ship a new stable version for every new stable IDEA. The ideal way is to run `runPluginVerifier` on CI for the latest version, which will fail the build, if our plugin isn't compatible. But for some reason, there is no EAP for IDEA 2022.3 here: https://jb.gg/intellij-platform-builds-list
|
We also need to release 1.1.2, because 1.1.1 is only compatible with IDEA 2022.1 |
|
It seems if we omit "until", it has a default value +8: https://plugins.jetbrains.com/plugin/16541-compose-multiplatform-ide-support/versions/Snapshots/223890 |
This was referenced Oct 4, 2022
YazaWainakh
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IDEA doesn't provide backward compatibility policy, and breaking changes can happen in any version, without prior deprecation:
https://plugins.jetbrains.com/docs/intellij/api-changes-list.html
Because of that, we can't remove(see Update)plugin.until.build, and have to build Compose plugin for each new version of IDEA separatelyUpdate 1:I removed plugin.until.build anyway. In most cases there won't be a broken plugin. And if it will be broken, we will know it during IDEA EAP. Considering this, better when users don't wait the new version, and use already available one.
Update 2:
If we omit plugin.until.build, then it has default value +8. Returned, but made the default value big enough.
What we should do after that commit, is make sure, that we don't forget to check this compatibility. And ship a new stable version for every new stable IDEA.
The ideal way is to run
runPluginVerifieron CI for the latest version, which will fail the build, if our plugin isn't compatible.But for some reason, there is no EAP for IDEA 2022.3 here:
https://jb.gg/intellij-platform-builds-list