Fix configuration cache issues #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aSemy
reviewed
Jan 9, 2023
Comment on lines
35
to
45
| fileOperations.clearDirs(outputDir) | ||
|
|
||
| for (file in skikoRuntimeFiles.files) { | ||
| if (file.name.endsWith(".jar", ignoreCase = true)) { | ||
| unpackJar(file) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun unpackSkikoRuntime(skikoVersion: String) { | ||
| val skikoRuntimeConfig = project.configurations.detachedConfiguration( | ||
| project.dependencies.create("org.jetbrains.skiko:skiko-js-wasm-runtime:$skikoVersion") | ||
| ) | ||
|
|
||
| for (file in skikoRuntimeConfig.resolve()) { | ||
| if (file.name.endsWith(".jar", ignoreCase = true)) { | ||
| project.copy { copySpec -> | ||
| copySpec.from(project.zipTree(file)) | ||
| copySpec.into(outputDir) | ||
| } | ||
| } | ||
| private fun unpackJar(file: File) { | ||
| fileOperations.copy { copySpec -> |
There was a problem hiding this comment.
If this used sync() instead of copy(), then there's no need for fileOperations.clearDirs(outputDir)
- Gradle will automatically create task directory properties tagged
@OutputDirectories - Sync will automatically delete old files
And then the new util file, gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/internal/utils/fileUtils.kt, isn't needed.
AlexeyTsvetkov
force-pushed
the
fix-configuration-cache-issues
branch
from
fea322c
to
2f1203c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.