Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow to assign null value in attr #780

Merged
merged 2 commits into from Jun 15, 2021
Merged

Don't allow to assign null value in attr #780

merged 2 commits into from Jun 15, 2021

Conversation

Schahen
Copy link
Collaborator

@Schahen Schahen commented Jun 15, 2021

Two changes:

  • (non-breaking) - always rewrite attributes completely because we don't have any attributes assigned from outside
  • (breaking) attr does not allow to set nulls - just don't call attr at all and it won't be added.

@Schahen Schahen changed the title Simplify attr application Don't allow to assign null value in attr Jun 15, 2021
@Schahen Schahen merged commit 4529645 into master Jun 15, 2021
@Schahen Schahen deleted the SIMPLIFY_ATTR_APPLICATION branch June 15, 2021 11:24
@hfhbd hfhbd mentioned this pull request Jun 16, 2021
Merged
eymar pushed a commit that referenced this pull request Jun 21, 2021
@hfhbd
web: Remove the boolean parameter from hidden() to align with #780 (#783
766e595 
)

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
mareklangiewicz pushed a commit to mareklangiewicz/compose-jb that referenced this pull request Feb 14, 2022
@Schahen @mareklangiewicz
Don't allow to assign null value in attr (JetBrains#780)
3b0f60f 
* Remove atrributes completely and reapply everything

Rather than keeping map with attributes applied

* Don't allow nullable signatures while calling attr
mareklangiewicz pushed a commit to mareklangiewicz/compose-jb that referenced this pull request Feb 14, 2022
@hfhbd @mareklangiewicz
web: Remove the boolean parameter from hidden() to align with JetBrai…
41e8dcb 
…ns#780 (JetBrains#783)

https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eymar eymar eymar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Schahen @eymar