web: align the rest of events #887
Conversation
eymar
force-pushed
the
web/other_events_refactoring
branch
from
7f77904
to
969c97f
Compare
eymar
changed the title
| * search event is not supported in Firefox, so we skip it for now | ||
| * https://caniuse.com/mdn-api_htmlinputelement_search_event | ||
| */ | ||
| const val SEARCH = "search" |
There was a problem hiding this comment.
let's remove this entirely
|
|
||
| fun onInput( | ||
| options: Options = Options.DEFAULT, | ||
| listener: (SyntheticInputEvent<T, HTMLInputElement>) -> Unit |
There was a problem hiding this comment.
new name = "ValueType"
done
| listener: (SyntheticMouseEvent) -> Unit | ||
| ) : SyntheticEventListener<SyntheticMouseEvent>(event, options, listener) { | ||
| override fun handleEvent(event: Event) { | ||
| listener(SyntheticMouseEvent(event.unsafeCast<MouseEvent>())) |
There was a problem hiding this comment.
let's choose one of two - either we use unsafeCast or as
There was a problem hiding this comment.
unsafeCast is now used in this and similar cases
| nativeEvent: Event, | ||
| ) : SyntheticEvent<EventTarget>(nativeEvent) { | ||
|
|
||
| val animationName: String = nativeEvent.asDynamic().animationName.unsafeCast<String>() |
There was a problem hiding this comment.
let's have external interface instead of asDynamic casts
There was a problem hiding this comment.
external interface AnimationEventDetails {
val animationName: String
}nativeEvent is of type Event, which is an external class, so our external interface can't inherit from the Event class.
So I added one more parameter to the constructor:
constructor(nativeEvent: Event, animationEventDetails: AnimationEventDetails)
and I use it like this:
SyntheticAnimationEvent(nativeEvent, nativeEvent.unsafeCast<AnimationEventDetails>())the constructor is internal, so I think it can be like this, since it's our internal thing.
| ) : SyntheticEvent<EventTarget>(nativeEvent) { | ||
|
|
||
| val altKey: Boolean = nativeEvent.altKey | ||
| val changedTouched: TouchList = nativeEvent.changedTouches |
There was a problem hiding this comment.
type: I guess it was supposed to be called changeTouches
| val box = driver.findElement(By.id("box")) | ||
|
|
||
| TouchActions(driver) | ||
| .down(box.rect.x + 50, box.rect.y + 50) |
There was a problem hiding this comment.
may it we can just check sizes and click sort of in the middle (or wherever we want to click)
* web: update change and beforeInput event listeners * web: update Clipboard events: copy, cut, paste * web: update Keyboard events: keyup, keydown * web: update select event (only for input and textarea) * web: update FocusEvents: focus, blur, focusin, focusout * web: update Touch Events * web: remove search event listener as it's not supported in Firefox * web: update Animation Events * web: update scroll event * web: rename WrappedEventListener to SyntheticEventListener * refactor internal event listeners to avoid redundant lambdas * remove WrappedEvent.kt * move SyntheticInputEvent.kt to `events` package * Add tests for Select element events * remove import from another changelist * web: add Form events: submit and reset * fix PR discussions * web: rename `attrsBuilder` to `attrs` Co-authored-by: Oleksandr Karpovich <oleksandr.karpovich@jetbrains.com>
No description provided.