Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kotlin 1.8.21 #3214

Closed
mgroth0 opened this issue May 28, 2023 · 11 comments
Closed

Support Kotlin 1.8.21 #3214

mgroth0 opened this issue May 28, 2023 · 11 comments
Assignees
Labels
compiler Compiler plugin related enhancement New feature or request wait for build

Comments

@mgroth0
Copy link

mgroth0 commented May 28, 2023

Kotlin 1.8.21 is not present on the compatibility chart, and using this kotlin version produces a warning or error.

@mgroth0 mgroth0 added bug Something isn't working submitted labels May 28, 2023
@dima-avdeev-jb
Copy link
Contributor

Thanks. We will fix it.

While you waiting, you can check the RC version of our compiler plugin.
To do this, add these lines to all your gradle modules:

compose {
    kotlinCompilerPlugin.set("org.jetbrains.compose.compiler:compiler:1.4.7-rc01")
    kotlinCompilerPluginArgs.add("suppressKotlinVersionCompatibilityCheck=1.8.21")
}

@dima-avdeev-jb dima-avdeev-jb added enhancement New feature or request compiler Compiler plugin related and removed bug Something isn't working submitted labels May 29, 2023
@JakeWharton
Copy link

Would be great to have your release support .22 as well since it's such an exceedingly minor bump (with no impact on a compiler plugins).

@JakeWharton
Copy link

JB Compose compiler 1.4.7 out yesterday supports 1.8.21 but does NOT support 1.8.22 😬.

@dima-avdeev-jb
Copy link
Contributor

JB Compose compiler 1.4.7 out yesterday supports 1.8.21 but does NOT support 1.8.22 😬.

Yeah, we are waiting for Google JetPack Compose compiler with support for 1.8.22 for now

@JakeWharton
Copy link

It's out today as 1.4.8. Would be amazing to get a fast-follow from you all so we can all be up-to-date before 1.9.

@dima-avdeev-jb
Copy link
Contributor

@eymar Do we plan to publish new Compose compiler with Kotlin 1.8.22 before next release of Compose Multiplatform?

@eymar
Copy link
Collaborator

eymar commented Jun 30, 2023

Do we plan to publish new Compose compiler with Kotlin 1.8.22 before next release of Compose Multiplatform?

It was not planned. Anyway, here it is: https://maven.pkg.jetbrains.space/public/p/compose/dev/org/jetbrains/compose/compiler/compiler/1.4.8/

it requires:

compose {
    kotlinCompilerPlugin.set("1.4.8")
}

cc: @JakeWharton

@eymar
Copy link
Collaborator

eymar commented Jun 30, 2023

kotlin 1.8.21 is currently supported with:

compose {
    kotlinCompilerPlugin.set("1.4.7")
}

We'll update the compatibility table when those versions are supported out of a box (w/o manual configuration)

closing this issue.

@eymar eymar closed this as completed Jun 30, 2023
@JakeWharton
Copy link

Thanks! Will that get synchronized to Maven Central so we can rely on it in places other than Compose UI multiplatform?

@eymar
Copy link
Collaborator

eymar commented Jun 30, 2023

Yes, 1.4.8 should be available in MavenCentral later today (rather soon, in ~1h)
cc: @JakeWharton

@JakeWharton
Copy link

Just got the notification. Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler Compiler plugin related enhancement New feature or request wait for build
Projects
None yet
Development

No branches or pull requests

4 participants