Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default headline for DatePicker displays incorrect date on iOS #3903

Closed
j-roskopf opened this issue Nov 6, 2023 · 4 comments
Closed

Default headline for DatePicker displays incorrect date on iOS #3903

j-roskopf opened this issue Nov 6, 2023 · 4 comments
Labels
bug Something isn't working submitted

Comments

@j-roskopf
Copy link
Contributor

j-roskopf commented Nov 6, 2023

Describe the bug
When using the DatePicker component with the default headline, the date displayed is incorrect on iOS, but displays fine for me on Android

Affected platforms

  • iOS

Versions

  • Kotlin version*: 1.9.20
  • Compose Multiplatform version*: 1.5.10
  • OS version(s)* (required for Desktop and iOS issues): iOS 17.0.1
  • OS architecture (x86 or arm64): arm64
  • JDK (for desktop issues):

To Reproduce
Steps and/or the code snippet to reproduce the behavior:

  1. Declare DatePicker
            val state = rememberDatePickerState()

            DatePicker(
                state = state,
                title = null,
            )
  1. Select date
  2. Observe headline value

Expected behavior
A clear and concise description of what you expected to happen.
Value should be correct / the same as what displays on Android

Screenshots
If applicable, add screenshots to help explain your problem.

Left is Android and right is iOS

compose_multi.mov

both devices are set to the same time + date

Screenshot 2023-11-05 at 8 52 56 PM
@j-roskopf j-roskopf added bug Something isn't working submitted labels Nov 6, 2023
@j-roskopf
Copy link
Contributor Author

j-roskopf commented Nov 6, 2023

I am also now noticing in the demo video above, the month header for the iOS date picker above the week day headline is labeled as October 2023, but it is November 2023
Screenshot 2023-11-05 at 9 10 37 PM

it seems like both monday + day are off by one

Screenshot 2023-11-05 at 9 12 14 PM

on iOS when the month dropdown is displaying November (above screenshot), it is displaying December, similar to what Android displays for December as well (below screenshot)
Screenshot 2023-11-05 at 9 12 40 PM

@alexzhirkevich
Copy link
Contributor

It was already fixed in JetBrains/compose-multiplatform-core#877 but sadly wasn't landed in latest release

@j-roskopf
Copy link
Contributor Author

ah gotchya, I'll close the issue. Is there an estimated version it would ship in that I can be on the lookout for?

Thanks!

@MatkovIvan
Copy link
Member

This will be included in 1.6.0 (even alpha's)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working submitted
Projects
None yet
Development

No branches or pull requests

3 participants