systemProperties contains absolute paths, creating remote build cache misses

[martinbonnin]

Hi 👋

Trying to enable remote build cache on apollo-kotlin, :intellij-plugin:test creates a cache misses (build scan).

This is due to the systemProperties input containing absolute paths. For an example, dumping the value of systemProperties:

tasks.named("test") {
  doFirst {
    println(inputs.properties.get("systemProperties"))
  }
}

Dumps this:

{idea.config.path=/Users/mbonnin/git/apollo-kotlin/intellij-plugin/build/idea-sandbox/config-test,
 idea.force.use.core.classloader=true, idea.home.path=/Users/mbonnin/git/apollo-kotlin/intellij-plugin/mockJDK, 
idea.log.path=/Users/mbonnin/git/apollo-kotlin/intellij-plugin/build/idea-sandbox/system-test/log, 
idea.plugins.path=/Users/mbonnin/git/apollo-kotlin/intellij-plugin/build/idea-sandbox/plugins-test, 
idea.system.path=/Users/mbonnin/git/apollo-kotlin/intellij-plugin/build/idea-sandbox/system-test, idea.use.core.classloader.for=,
 idea.use.core.classloader.for.plugin.path=true, java.system.class.loader=com.intellij.util.lang.PathClassLoader, 
jdk.attach.allowAttachSelf=true, jdk.http.auth.tunneling.disabledSchemes="", jdk.module.illegalAccess.silent=true, 
kotlinx.coroutines.debug=off, plugin.path=/Users/mbonnin/git/apollo-kotlin/intellij-plugin/build/idea-sandbox/plugins-
test/toml:,/Users/mbonnin/git/apollo-kotlin/intellij-plugin/build/idea-sandbox/plugins-test/js-graphql-intellij-
plugin:,/Users/mbonnin/git/apollo-kotlin/intellij-plugin/build/idea-sandbox/plugins-test/apollo-intellij-plugin, 
sun.io.useCanonCaches=false, sun.java2d.metal=true}

Would it be possible to make those relative instead?

[runningcode]

Here is how you can change these paths to use relative path sensitivity: https://docs.gradle.org/current/userguide/caching_java_projects.html#dealing_with_file_paths

[hsz]

Could you folks please verify the fix with 1.14.2-SNAPSHOT release?

[martinbonnin]

It's working 🎉 Build scan comparison: https://ge.apollographql.com/c/tio3mycqe52gw/hutlgsgajznwe/task-inputs

We're down from ~40s to ~3s with build cache.

[hsz]

@martinbonnin Thank you for the confirmation!
@runningcode This link was super helpful, thanks!