Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify about overriding any attribute in plugin.xml #284

Closed
zolotov opened this issue May 16, 2018 · 2 comments
Closed

Notify about overriding any attribute in plugin.xml #284

zolotov opened this issue May 16, 2018 · 2 comments
Assignees
Milestone

Comments

@zolotov
Copy link
Member

zolotov commented May 16, 2018

No description provided.

@zolotov zolotov self-assigned this May 16, 2018
@hairybreeches
Copy link

I think I'm seeing this problem. My plugin.xml has the parameter

<idea-version since-build="162"/>

but the output into build/patchedPluginXmlFiles/plugin.xml has it changed to

<idea-version since-build="182.2949" until-build="182.*"/>

Changing this value means that I can't run my plugin in datagrip. When I try to run datagrip using the "alternativeIdePath", I get

WARN: pgMustard not loaded: since build 182.2949 > DB-181.5087.33

Which is frustrating, since that's not what I wanted the since-build parameter to be! I think that it's the gradle plugin that's substituting in 182.2949 for the since-build parameter - I can't find any uses at all of that version number in my project (outside the build directory).

Am I right that it's the plugin making this substitution? If so, how do I make it stop?

@zolotov
Copy link
Member Author

zolotov commented Jun 13, 2018

@hairybreeches

<idea-version since-build="162"/>

Have you really verified that your plugin works on DB 2016.1? If not, you must not do this.

WARN: pgMustard not loaded: since build 182.2949 > DB-181.5087.33

If you want to build a plugin for DB-181.* it's highly recommended to use 181.* platform for compiling. Using 182.* platform for it and patching the plugin.xml is antipattern.

Am I right that it's the plugin making this substitution?

Yes, it's stated in the README.md.

If so, how do I make it stop?

You should not, but if you still want, please find a minute to read the README.md, couple ways described are described there.

@zolotov zolotov added this to the 0.4.0 milestone Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants