Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move signPlugin file name creation to lazy #742

Merged
merged 4 commits into from
Jul 15, 2021
Merged

Conversation

brian-mcnamara
Copy link
Contributor

@brian-mcnamara brian-mcnamara commented Jul 14, 2021

Related to: https://jetbrains-platform.slack.com/archives/CPL5291JP/p1626141308142300

Fixes issue where plugin version is specified in the build.gradle file where the filename with the version is generated after initialization. This prevented the output of signPlugin from containing the version.

@zolotov
Copy link
Member

zolotov commented Jul 15, 2021

thanks, it looks very good to me. @hsz please take a look too

@hsz hsz merged commit 2ac2397 into JetBrains:master Jul 15, 2021
@hsz
Copy link
Member

hsz commented Jul 15, 2021

Thanks, Brian!

@brian-mcnamara brian-mcnamara deleted the lazy branch July 16, 2021 04:33
@hsz hsz added this to the next milestone Jul 16, 2021
@hsz hsz added the bug label Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants